Merge commit '9b36dd9d9952851d842c2f3bc6fadb0f9e4d8fa7'

external/toxcore/c-toxcore/.github/scripts/flags-gcc.sh

@@ -22,7 +22,6 @@ add_flag -Wframe-larger-than=9000
 add_flag -Wignored-attributes
 add_flag -Wignored-qualifiers
 add_flag -Winit-self
-add_flag -Winline
 add_flag -Wlarger-than=530000
 add_flag -Wmaybe-uninitialized
 add_flag -Wmemset-transposed-args
@@ -45,6 +44,8 @@ add_flag -Wunused-value
 
 # Disable specific warning flags for both C and C++.
 
+# Not important, and bothersome with lambdas in C++.
+add_flag -Wno-inline
 # struct Foo foo = {0}; is a common idiom.
 add_flag -Wno-missing-field-initializers
 # Checked by clang, but gcc is warning when it's not necessary.

external/toxcore/c-toxcore/.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        tool: [autotools, clang-tidy, compcert, cppcheck, doxygen, goblint, infer, misra, modules, pkgsrc, rpm, slimcc, sparse, tcc, tokstyle]
+        tool: [autotools, clang-tidy, compcert, cppcheck, doxygen, infer, misra, modules, pkgsrc, rpm, slimcc, sparse, tcc, tokstyle]
     runs-on: ubuntu-22.04
     steps:
       - name: Set up Docker Buildx
@@ -178,10 +178,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-      - name: Set up Python 3.9
+      - name: Set up Python 3.12
         uses: actions/setup-python@v5
         with:
-          python-version: 3.9
+          python-version: 3.12
       - name: Install mypy
         run: pip install mypy
       - name: Run mypy

external/toxcore/c-toxcore/.github/workflows/codeql.yml

@@ -0,0 +1,57 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ "master" ]
+  schedule:
+    - cron: '39 10 * * 0'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'cpp' ]
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+      with:
+        submodules: recursive
+
+    - name: Install dependencies
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y --no-install-recommends \
+          libconfig-dev \
+          libopus-dev \
+          libsodium-dev \
+          libvpx-dev \
+          ninja-build \
+          pkg-config
+
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v3
+      with:
+        languages: ${{ matrix.language }}
+        queries: security-and-quality
+
+    - name: Build
+      run: |
+        cmake -GNinja -B _build -S .
+        cmake --build _build --parallel $(nproc)
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v3
+      with:
+        category: "/language:${{ matrix.language }}"

external/toxcore/c-toxcore/.github/workflows/docker.yml

@@ -138,7 +138,7 @@ jobs:
       - name: Build and store to local Docker daemon
         uses: docker/build-push-action@v5
         with:
-          context: other/docker/windows
+          file: other/docker/windows/windows.Dockerfile
           load: true
           tags: toxchat/windows:win${{ matrix.bits }}
           cache-from: type=registry,ref=toxchat/windows:win${{ matrix.bits }}
@@ -150,7 +150,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: docker/build-push-action@v5
         with:
-          context: other/docker/windows
+          file: other/docker/windows/windows.Dockerfile
           push: ${{ github.event_name == 'push' }}
           tags: toxchat/windows:win${{ matrix.bits }}
           build-args: |